[Galene] Re: Need explanation on protocol

[Goffi <goffi@goffi.org>]

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

Le lundi 22 juillet 2024, 20:26:58 UTC+2 Juliusz Chroboczek a écrit :
> > https://repos.goffi.org/libervia-backend/file/tip/libervia/backend/plugins/
plugin_comp_conferences/__init__.py#l130
> 
> Ah, I think I see the problem.
> 
> There's the client id, and there's the stream id.  You're reusing the
> client id as the stream id, and that's not correct: if a client publishes
> multiple streams, they must choose different ids.
> 
> So you should be doing something like:
> 
>    def send_offer(self, session: dict, sdp: str) -> None:
>        ...
>                 "id": str(uuid()),
>        ...
> 
> instead of self["id"].
> 
> -- Juliusz
> 
> 
> _______________________________________________
> Galene mailing list -- galene@lists.galene.org
> To unsubscribe send an email to galene-leave@lists.galene.org
> 

Alright,

I think that I've got it.

I was somehow thinking that Galène created a whole new ID when forwarding a 
stream, so when I received the identical ID as my offer, I thought it was 
Louise's stream sent to me. But actually, it was my stream sent to Louise 
using the other client (both are handled by the same instance, hence my 
confusion).

By logging the client ID, I see now what is happening, and I should be able to 
fix my code.

Thanks a lot for your help and work on Galène!

Best,
Goffi

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]