Galène videoconferencing server discussion list archives
 help / color / mirror / Atom feed
From: Juliusz Chroboczek <jch@irif.fr>
To: "Michael Ströder" <michael@stroeder.com>
Cc: galene@lists.galene.org
Subject: [Galene] Re: coturn config
Date: Thu, 07 Jan 2021 14:27:44 +0100	[thread overview]
Message-ID: <87ble0dghb.wl-jch@irif.fr> (raw)
In-Reply-To: <43734076-b64d-a4ad-bd44-2e3266aa8d07@stroeder.com>

> I'm already using this (with git revision d2f7010) since 2+ days. No
> issues so far.

Excellent.

> How to ensure that it survived key rotation?

Keep Galène running for more than 24h after the initial key is generated
(which happens the first time a client joins).  If the group is still
accessible, then key rotation was successful.

I've got unit tests for key rotation, but not for key rotation.  See
ice/ice_test.go.

> Does key rotation affect existing TURN sessions?

No.  It doesn't even affect existing client sessions, you need to leave
the group and re-join in order to get a new key.  The protocol supports
rotating a joined client's keys, but doing that properly would require
maintaining key age for each client, so I didn't bother for now.

A new key is generated every 2 to 5 minutes, and it has a validity of 24h,
so you'll only run into the issue if you remain connected for (24h - 5min).

In case anyone wants to hack on it, here's what's needed:

  - maintain credential age somewhere in the client structure;
  - at the right time, launch a goroutine to send
    { type: "join", kind: "changed"} to all clients nearing expiration;
  - for extra credit, trigger an ICE restart for all streams to and from
    affected clients so that existing streams pick up the new TURN
    credentials; not sure if that's better done in the client or in the
    server (either side can trigger a restart).

> Maybe some logging would be good.

Yeah.

-- Juliusz

      parent reply	other threads:[~2021-01-07 13:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-27 16:57 [Galene] " Cell
2020-12-27 17:55 ` [Galene] " Toke Høiland-Jørgensen
2020-12-27 18:02 ` Cell
2020-12-27 18:06 ` Cell
2020-12-27 18:16   ` Toke Høiland-Jørgensen
2020-12-27 19:04 ` Juliusz Chroboczek
2020-12-27 19:27   ` Juliusz Chroboczek
2020-12-27 20:32     ` Toke Høiland-Jørgensen
2020-12-27 23:28       ` Juliusz Chroboczek
2020-12-28  1:38         ` Toke Høiland-Jørgensen
2020-12-28 18:49           ` Juliusz Chroboczek
2020-12-28 19:59             ` Toke Høiland-Jørgensen
2020-12-29  1:56               ` Juliusz Chroboczek
2020-12-29  2:09                 ` Toke Høiland-Jørgensen
2020-12-29  8:35                   ` Michael Ströder
2021-01-01 22:55               ` Juliusz Chroboczek
2021-01-01 23:43                 ` Gabriel Kerneis
2021-01-02  0:02                   ` Juliusz Chroboczek
2021-01-07 12:07                 ` Michael Ströder
2021-01-07 12:14                   ` Toke Høiland-Jørgensen
2021-01-07 12:31                     ` [Galene] logging (was: coturn config) Michael Ströder
2021-01-07 13:27                   ` Juliusz Chroboczek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.galene.org/postorius/lists/galene.lists.galene.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ble0dghb.wl-jch@irif.fr \
    --to=jch@irif.fr \
    --cc=galene@lists.galene.org \
    --cc=michael@stroeder.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox