[Galene] Heads up: file transfer now handled by protocol.js

[Galene] Heads up: file transfer now handled by protocol.js

[Juliusz Chroboczek]

Hi,

I've just reworked the file transfer code so it's split into a protocol
part (in protocol.js) and a user-interface part (in galene.js).  The new
code uses an explicit state machine, and therefore should have much better
error handling (in particular, you'll no longer see a file transfer hang
if the peer goes away).  Please test.

Unfortunately, this means that if you're maintaining and alternate client
and you've reimplemented file transfer, I've just made part of your work
obsolete.  Sorry, Jeroen.

In case anyone is interested, the new code is here:

  https://github.com/jech/galene/blob/master/static/galene.js#L2415

Yes, that's all there is to it :-)

-- Juliusz

[Galene] Re: Heads up: file transfer now handled by protocol.js

[Jeroen van Veen]

Hey Juliusz,

Good idea! That makes it easier to keep this feature in sync for both clients.
I'll adapt the code as soon I got the UI for file transfer ready.

cheers,

Jeroen

------- Original Message -------
Op maandag 25 juli 2022 om 7:27 PM schreef Juliusz Chroboczek <jch@irif.fr>:


>
>
> Hi,
>
> I've just reworked the file transfer code so it's split into a protocol
> part (in protocol.js) and a user-interface part (in galene.js). The new
> code uses an explicit state machine, and therefore should have much better
> error handling (in particular, you'll no longer see a file transfer hang
> if the peer goes away). Please test.
>
> Unfortunately, this means that if you're maintaining and alternate client
> and you've reimplemented file transfer, I've just made part of your work
> obsolete. Sorry, Jeroen.
>
> In case anyone is interested, the new code is here:
>
> https://github.com/jech/galene/blob/master/static/galene.js#L2415
>
> Yes, that's all there is to it :-)
>
> -- Juliusz
> _______________________________________________
> Galene mailing list -- galene@lists.galene.org
> To unsubscribe send an email to galene-leave@lists.galene.org