From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=irif.fr header.i=@irif.fr header.a=rsa-sha256 header.s=dkim-irif header.b=FJ77YhAV; arc=none (Message is not ARC signed); dmarc=none Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) by mail.toke.dk (Postfix) with ESMTPS id 24C53194EBB3 for ; Fri, 30 Oct 2026 12:16:14 +0100 (CET) Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id 69UBG0oD017345; Fri, 30 Oct 2026 12:16:00 +0100 Received: from mailhub.math.univ-paris-diderot.fr (unknown [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 811C7679B0; Fri, 30 Oct 2026 12:16:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=irif.fr; h= content-type:content-type:mime-version:user-agent:references :in-reply-to:subject:subject:from:from:message-id:date:date :received:received; s=dkim-irif; t=1793358959; x=1794222960; bh= IuQylwqb2v/Wy38qEIvmx4/0j6BqhwQcDXSaiWaudwU=; b=FJ77YhAVvVcBbHtA hGqzVXVUSQcOOV07KpwEG3LIaVviaSqYDvrZpHPAVKrzVwgwLx0EPMB2wSbD4VmC LF2QhrKZ0xub2R4rPuJXdoP6+KC4BVT3kf7YOpvPVpJCWJ5S14Mq2+Y5KEfri1sS 5HJ6fkrYgYS5O8hHfLIJJU8lNhn/f6BL1yHc4G9NH/EUwGUhaHoW7r7dNh1JsAO5 BQnEwJH2VhmKlN9pJ+2stOBrfiD42OYGL8IFjOZyTmu1NE7weRnrdvL4g3HCuTNs ZmhBh8mDlDaBFpzvFj4aALgx/kn39xh91yNbS7RVrhn0UlVVyK3fiR/lo08mIGII L4Eyhw== X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id fSpG-kxNuD2l; Fri, 30 Oct 2026 12:15:59 +0100 (CET) Received: from trurl.irif.fr (unknown [82.64.191.149]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 007F2676FD; Fri, 30 Oct 2026 12:15:58 +0100 (CET) Date: Fri, 30 Oct 2026 12:15:58 +0100 Message-ID: <87tsm3e8wh.wl-jch@irif.fr> From: Juliusz Chroboczek To: Stefan Bethke Cc: galene@lists.galene.org In-Reply-To: <121CCD01-E105-4A60-8BAA-1FDC7865F5C6@lassitu.de> References: <988C59EA-3721-46A7-A301-908CC8BCB960@lassitu.de> <87qzhkmpa4.wl-jch@irif.fr> <121CCD01-E105-4A60-8BAA-1FDC7865F5C6@lassitu.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [194.254.61.138]); Fri, 30 Oct 2026 12:16:00 +0100 (CET) X-Miltered: at korolev with ID 6AE47C70.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)! X-j-chkmail-Enveloppe: 6AE47C70.000 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/ X-j-chkmail-Score: MSGID : 6AE47C70.000 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000 X-j-chkmail-Status: Ham Message-ID-Hash: NJKA42YNDRPK44N65OIODOO52W7DKVIP X-Message-ID-Hash: NJKA42YNDRPK44N65OIODOO52W7DKVIP X-MailFrom: jch@irif.fr X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Galene] Re: Additional stats List-Id: =?utf-8?q?Gal=C3=A8ne_videoconferencing_server_discussion_list?= Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > here is my proposal: https://github.com/jech/galene/pull/349 Thanks, especially for mentioning explicitly that you used Claude to write this code. Unfortunately, your code has the typical flaws of LLM-generated code: - it's a single commit, with a verbose but useless commit message; - there are a number of changes that are unrelated to Prometheus, that are bundled into the same commit; - the comments are verbose and not useful; - the code is overly verbose, with no clear indication which features are actually useful; - doc strings and comments paraphrase the code rather than providing information that's useful to the reader. For now, I suggest you extract the changes unrelated to Prometheus and submit them in a separate PR. Before we decide whether to work on improving the code, I'd like to understand two things. 1. Do people actually feel that this kind of metrics are useful to include in Galene? How do people use Prometheus usually, what insights does it give you, and are these insights useful? Or do people just want Prometheus because it's what everyone does? (As far as I'm concerned, I optimise Galene by running it in production with profiling enabled, then spend some time poring over the profile. I find the output of a profiler much more useful, as it gives me a global view of the behaviour, not just the specific set of statistics that are exported by the monitoring interface.) 2. Are you actually using this code in production, and have you found the provided statistics useful for administering Galene? Thanks again, -- Juliusz