From: Jeroen van Veen <jvanveen@protonmail.com>
To: Juliusz Chroboczek <jch@irif.fr>
Cc: galene@lists.galene.org
Subject: [Galene] Re: Heads up: file transfer now handled by protocol.js
Date: Fri, 12 Aug 2022 11:00:19 +0000 [thread overview]
Message-ID: <AwH5R9F8zeQjc9ulSPCTbJYxbd_CfS66Tgnf-wiXdH8LlocQqkk4sSqq8CfOa0jC5r9IpKt0_qWtT1wfBN2HwBqvQuke1ltWgdxYyz20oN0=@protonmail.com> (raw)
In-Reply-To: <87r129umq0.wl-jch@irif.fr>
Hey Juliusz,
Good idea! That makes it easier to keep this feature in sync for both clients.
I'll adapt the code as soon I got the UI for file transfer ready.
cheers,
Jeroen
------- Original Message -------
Op maandag 25 juli 2022 om 7:27 PM schreef Juliusz Chroboczek <jch@irif.fr>:
>
>
> Hi,
>
> I've just reworked the file transfer code so it's split into a protocol
> part (in protocol.js) and a user-interface part (in galene.js). The new
> code uses an explicit state machine, and therefore should have much better
> error handling (in particular, you'll no longer see a file transfer hang
> if the peer goes away). Please test.
>
> Unfortunately, this means that if you're maintaining and alternate client
> and you've reimplemented file transfer, I've just made part of your work
> obsolete. Sorry, Jeroen.
>
> In case anyone is interested, the new code is here:
>
> https://github.com/jech/galene/blob/master/static/galene.js#L2415
>
> Yes, that's all there is to it :-)
>
> -- Juliusz
> _______________________________________________
> Galene mailing list -- galene@lists.galene.org
> To unsubscribe send an email to galene-leave@lists.galene.org
prev parent reply other threads:[~2022-08-12 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 17:27 [Galene] " Juliusz Chroboczek
2022-08-12 11:00 ` Jeroen van Veen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.galene.org/postorius/lists/galene.lists.galene.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AwH5R9F8zeQjc9ulSPCTbJYxbd_CfS66Tgnf-wiXdH8LlocQqkk4sSqq8CfOa0jC5r9IpKt0_qWtT1wfBN2HwBqvQuke1ltWgdxYyz20oN0=@protonmail.com' \
--to=jvanveen@protonmail.com \
--cc=galene@lists.galene.org \
--cc=jch@irif.fr \
--subject='[Galene] Re: Heads up: file transfer now handled by protocol.js' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox