From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=lassitu.de header.i=@lassitu.de header.a=rsa-sha256 header.s=dkim header.b=O84a2EkT; arc=none (Message is not ARC signed); dmarc=none Received: from jan.hanse.de (jan.hanse.de [IPv6:2a00:14b0:f001:100::fc]) by mail.toke.dk (Postfix) with ESMTPS id 55D1E194F85D for ; Fri, 30 Oct 2026 14:19:18 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DD582EEA732; Fri, 30 Oct 2026 14:19:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassitu.de; s=dkim; t=1793366357; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=FebAoXLYTnuoFlzCjom5RZa0qCdI/9aec2SuiSIwf68=; b=O84a2EkTQYxamBG57BiwkqbDk2iRfUnKvw5wkD1An7+Xi0Xlz15cLy4IU1wMpZjT9b1+CT bQs8O2PqvB866asAeLx52SsKfl+XJe5SJqy5i7yvuMAD4xCr5N8oZ/Be34q4XsAEE2iKmv rEsSW7DY9p+XuV4YR4wxa8Uj9HkCzrlv9KTlhOD3peeNDEoOj4BUjSk2WFt6cUOKh43DvI CEkghLDbFD8CkZtuF9Z1vjBS2fFWT7d3Um7Re2AuxPeii8YPoQqL3gzaJoo/3BSPwiecBB 0kESBg2wGIPH0+6TtUDfJlQQIYsAFtu9kHAOlvmb3jkUuVJEcEc1kwU2zBKheg== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.200.71.1.16\)) From: Stefan Bethke In-Reply-To: <874ie3l5jy.wl-jch@irif.fr> Date: Fri, 30 Oct 2026 14:19:15 +0100 Cc: galene@lists.galene.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <988C59EA-3721-46A7-A301-908CC8BCB960@lassitu.de> <87qzhkmpa4.wl-jch@irif.fr> <121CCD01-E105-4A60-8BAA-1FDC7865F5C6@lassitu.de> <87tsm3e8wh.wl-jch@irif.fr> <874ie3l5jy.wl-jch@irif.fr> To: Juliusz Chroboczek X-Mailer: Apple Mail (2.3901.200.71.1.16) X-Last-TLS-Session-Version: TLSv1.2 Message-ID-Hash: 7BBOUFPXONU4L3ATH7LIEAKC5DZS2TOS X-Message-ID-Hash: 7BBOUFPXONU4L3ATH7LIEAKC5DZS2TOS X-MailFrom: stb@lassitu.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Galene] Re: Additional stats List-Id: =?utf-8?q?Gal=C3=A8ne_videoconferencing_server_discussion_list?= Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 30. Oct 2026, at 13:46, Juliusz Chroboczek wrote: >=20 >> I am running a test instance and are monitoring that through it. We = will >> use this feature in the production setup December 27th to 30th at the >> 40th Chaos Communication Congress. >=20 > Wow! That's excellent news. >=20 >> * We would like some fancy graphs because they are cool >=20 > That almost convinced me ;-) >=20 > Now, there are good reasons why I couldn't possibly apply your patch = in > its current state. >=20 > - It needs careful review in order to ensure that we don't expose = private > user data. Respecting user privacy is an important feature of = Galene, > and one I won't compromise on. I completely agree, and I wouldn't want to suggest code that would leak = such info. > - There is no evidence that the provided metrics are the ones we = want. > Experience shows that once you include a feature, it's difficult to > remove (XKCD 1172), so I'd like to make sure that we only include = those > metrics that we actually need. Good point. Happy to pick this up again after we've had practical = experience in December. > - It is verbose and redundant, as typical of Claude. This makes it > difficult to review, and will make it difficult to maintain in the > long term. This makes the first point difficult to satisfy. I am still not sure I follow. Can you point out an example? > I suggest the following: >=20 > 1. Extract the non-Prometheus relasted changes, and submit them in > a separate PR. That will make your fork closer to upstream. The changes to the authentication code are necessary to implement access = control for the metrics endpoint, but they do not provide any = functionality by themselves. I'm happy to put them in a separate commit = to make it clear that they are enabling changes, but I would suggest = they should only go in together with the metrics endpoint. > 2. Run your code as a (friendly) fork until you get more experience. > After running your code during CCC, you'll know which metrics are > useful and which ones are missing. >=20 > 3. After CCC, we can discuss whether we want to work on rewriting the = code > in a human-readable manner, or whether we want to give up. Sure thing. Stefan --=20 Stefan Bethke Fon +49 175 3288861