[Galene] Re: Additional stats

[Juliusz Chroboczek <jch@irif.fr>]

> I am running a test instance and are monitoring that through it. We will
> use this feature in the production setup December 27th to 30th at the
> 40th Chaos Communication Congress.

Wow!  That's excellent news.

> * We would like some fancy graphs because they are cool

That almost convinced me ;-)

Now, there are good reasons why I couldn't possibly apply your patch in
its current state.

  - It needs careful review in order to ensure that we don't expose private
    user data.  Respecting user privacy is an important feature of Galene,
    and one I won't compromise on.

  - There is no evidence that the provided metrics are the ones we want.
    Experience shows that once you include a feature, it's difficult to
    remove (XKCD 1172), so I'd like to make sure that we only include those
    metrics that we actually need.

  - It is verbose and redundant, as typical of Claude.  This makes it
    difficult to review, and will make it difficult to maintain in the
    long term.  This makes the first point difficult to satisfy.

I suggest the following:

1. Extract the non-Prometheus relasted changes, and submit them in
   a separate PR.  That will make your fork closer to upstream.

2. Run your code as a (friendly) fork until you get more experience.
   After running your code during CCC, you'll know which metrics are
   useful and which ones are missing.

3. After CCC, we can discuss whether we want to work on rewriting the code
   in a human-readable manner, or whether we want to give up.

-- Juliusz