[Galene] Re: Additional stats

[Juliusz Chroboczek <jch@irif.fr>]

> here is my proposal: https://github.com/jech/galene/pull/349

Thanks, especially for mentioning explicitly that you used Claude to write
this code.

Unfortunately, your code has the typical flaws of LLM-generated code:

  - it's a single commit, with a verbose but useless commit message;

  - there are a number of changes that are unrelated to Prometheus, that
    are bundled into the same commit;

  - the comments are verbose and not useful;

  - the code is overly verbose, with no clear indication which features
    are actually useful;

  - doc strings and comments paraphrase the code rather than providing
    information that's useful to the reader.

For now, I suggest you extract the changes unrelated to Prometheus and
submit them in a separate PR.  Before we decide whether to work on
improving the code, I'd like to understand two things.

1. Do people actually feel that this kind of metrics are useful to include
   in Galene?  How do people use Prometheus usually, what insights does it
   give you, and are these insights useful?  Or do people just want
   Prometheus because it's what everyone does?

   (As far as I'm concerned, I optimise Galene by running it in production
   with profiling enabled, then spend some time poring over the profile.
   I find the output of a profiler much more useful, as it gives me
   a global view of the behaviour, not just the specific set of statistics
   that are exported by the monitoring interface.)

2. Are you actually using this code in production, and have you found the
   provided statistics useful for administering Galene?

Thanks again,

-- Juliusz