[Galene] 0.4 tag & locked/unlocked state available?

[Galene] 0.4 tag & locked/unlocked state available?

[Jeroen van Veen]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi!

I'm currently wiring the user-context/room-context menus in Pyrite and want to switch
to Galene 0.4, to test with user states. Is it possible to have a git tag for the new 0.4?
I'm not sure if go get works with commithashes? e.g. https://github.com/garage44/pyrite/blob/develop/docker/galene/Dockerfile#L5

Maybe this is already tackled in 0.4, but is it possible to know wheth a group is locked or not?
I would like to show a locked icon in the groups list (/public-groups.json)
But it may also be useful to know within a group whether its being locked by an admin.

Jeroen

[-- Attachment #2: Type: text/html, Size: 1163 bytes --]

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Juliusz Chroboczek]

> Is it possible to have a git tag for the new 0.4?

Not yet, sorry, I've got at least one client-side bug that I need to fix
(for example, the camera is currently not being closed and reopened when
you toggle blackboard mode, which prevents the resolution from changing).
If it's useful for you, I can tag it with a less attractive version
number, though, such as 0.3.99.0.

> Maybe this is already tackled in 0.4, but is it possible to know wheth a group
> is locked or not?

Good idea, I'll add that information to the "joined" message (and generate
joined/changed whenever it changes).  Please give me until dawn.

-- Juliusz

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Michael Ströder]

On 7/16/21 4:06 PM, Juliusz Chroboczek wrote:
>> Is it possible to have a git tag for the new 0.4?
> 
> Not yet, sorry, [..]
> If it's useful for you, I can tag it with a less attractive version
> number, though, such as 0.3.99.0.

Nitpicking with downstream packager hat on:

Please do not tag as 0.3.99.0 because with semantic versioning this
would be a release newer than 0.3.0 and not a 0.4.0 pre-release.

Ciao, Michael.

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Juliusz Chroboczek]

> Please do not tag as 0.3.99.0 because with semantic versioning this
> would be a release newer than 0.3.0 and not a 0.4.0 pre-release.

Do you have any better suggestions?

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Jeroen van Veen]

No need to make an extra tag; I just found out that go get also works fine with git hashes and published
a new version of garage44/galene:latest to Dockerhub. Would it be possible to have the locked status also
available from the public-groups endpoint? (/public-groups.json) Pyrite uses it to show available groups
in the main view. With a joined message, it would be useful to change the group's state while being
connected , but not when showing a list of groups before connecting right?

-- Jeroen

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

Op vrijdag 16 juli 2021 om 4:06 PM schreef Juliusz Chroboczek <jch@irif.fr>:

> > Is it possible to have a git tag for the new 0.4?
>
> Not yet, sorry, I've got at least one client-side bug that I need to fix
>
> (for example, the camera is currently not being closed and reopened when
>
> you toggle blackboard mode, which prevents the resolution from changing).
>
> If it's useful for you, I can tag it with a less attractive version
>
> number, though, such as 0.3.99.0.
>
> > Maybe this is already tackled in 0.4, but is it possible to know wheth a group
> >
> > is locked or not?
>
> Good idea, I'll add that information to the "joined" message (and generate
>
> joined/changed whenever it changes). Please give me until dawn.
>
> -- Juliusz
>
> Galene mailing list -- galene@lists.galene.org
>
> To unsubscribe send an email to galene-leave@lists.galene.org

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Gabriel Kerneis]

On Fri, 16 Jul 2021, at 16:15, Juliusz Chroboczek wrote:
> > Please do not tag as 0.3.99.0 because with semantic versioning this
> > would be a release newer than 0.3.0 and not a 0.4.0 pre-release.
> 
> Do you have any better suggestions?

This became a moot point since Jeroen found a workaround, but for the sake of completeness https://semver.org/#spec-item-9 recommends something like 0.4.0-alpha in such cases.

Gabriel

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Michael Ströder]

On 7/16/21 4:15 PM, Juliusz Chroboczek wrote:
>> Please do not tag as 0.3.99.0 because with semantic versioning this
>> would be a release newer than 0.3.0 and not a 0.4.0 pre-release.
> 
> Do you have any better suggestions?

See the suggested ordering matching rules in semantic versioning:

https://semver.org/#spec-item-11

The question is whether a tag is really needed by client devs.

When packaging Galène from latest git revision I usually use a package
base version like this:

0.4.0~<timestamp>

With 0.4.0 being the next planned revision.

Package version would then be something like:

0.4.0~<timestamp>-1.1

Some downstream packagers sometimes use git revisions instead of a
timestamp. Personally I prefer monotonically increasing timestamps.

AFAIK the tilde is commonly used by downstream packagers for suffixing
pre-releases because 0.4.0-1 would considered be a later release
following 0.4.0~<whatever> by package managers.

Ciao, Michael.

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Juliusz Chroboczek]

>> Maybe this is already tackled in 0.4, but is it possible to know wheth a group
>> is locked or not?

> Good idea, I'll add that information to the "joined" message (and generate
> joined/changed whenever it changes).  Please give me until dawn.

Done.  There is now an extra field called "status" in the "joined"
message, it contains a dictionary of the form

  {
      "displayName": "Friendly group name",
      "locked": true,
  }

Please treat the "locked" field as a generalised boolean, as it might get
a different true value in the future (e.g., a string).

      

[Galene] Re: 0.4 tag & locked/unlocked state available?

[Juliusz Chroboczek]

> I would like to show a locked icon in the groups list (/public-groups.json)

Done, you now get two optional fields "displayName" and "locked" in the
public groups list.  You should use "name" when "displayName" is absent.

[Galene] Re: tagging and semver

[Juliusz Chroboczek]

>>> would be a release newer than 0.3.0 and not a 0.4.0 pre-release.

>> Do you have any better suggestions?

> The question is whether a tag is really needed by client devs.

It's convenient.  If you have some time, I'd like us to design a tagging
scheme that allows me to tag pre-release versions without making
packagers' lives uselessly complicated.

Galène does not use semantic versioning, which is the reason why my tags
are of the form « galene-0.3.4 » rather than « v0.3.4 » (the latter would
imply semver).  Callling pre-release versions « galene-0.3.99.x » is the
logical thing for me, since it preserves the ordering on release
numbers -- Debian-style « 0.4.0pre3 » uses a negative digit, which I find
confusing.

  https://en.wikipedia.org/wiki/Quater-imaginary_base

Given that Galène does not use semantic versioning, do I cause actual
problems if I create a tag « galene-0.3.99.0 » ?

-- Juliusz