From: Juliusz Chroboczek <jch@irif.fr>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: galene@lists.galene.org
Subject: [Galene] Re: Frozen videos [was: use of closed network connection]
Date: Sun, 14 Feb 2021 17:32:39 +0100 [thread overview]
Message-ID: <87mtw6k3tk.wl-jch@irif.fr> (raw)
In-Reply-To: <87im6zr7hy.fsf@toke.dk>
> Feb 10 20:25:25 video galene[1251625]: 2021/02/10 20:25:25 Replace: file does not exist
> I also have frozen video frame of a user that left stuck in the group
> view now (but he's not in the user list).
This should be fixed now.
We were pushing connections asynchronously, which could cause the push
actions to arrive in the wrong order: if a connection was created and then
deleted, the deletion could arrive before the creation, in which case the
deletion would log a warning (file does not exist) and the creation would
succeed, leaving a frozen video.
Of course, we cannot just replace asynchronous with synchronous, as that
might cause deadlocks. So I've had to implement an explicit queue of
pending actions, and make communication between threads use unbounded
amounts of buffering.
Personal opinion -- I much prefer the semantics of Erlang's mailboxes
(which implement unbounded buffering) to that of Go's channels (which use
bounded amounts of buffering, and are therefore susceptible to deadlocks).
-- Juliusz
next prev parent reply other threads:[~2021-02-14 16:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 19:04 [Galene] New Galène protocol Juliusz Chroboczek
2021-02-03 21:01 ` [Galene] " Michael Ströder
2021-02-03 21:11 ` Juliusz Chroboczek
2021-02-04 10:49 ` Michael Ströder
2021-02-04 18:27 ` Michael Ströder
2021-02-04 20:04 ` Juliusz Chroboczek
2021-02-04 20:47 ` Michael Ströder
2021-02-04 21:26 ` Michael Ströder
2021-02-04 21:57 ` Juliusz Chroboczek
2021-02-04 22:06 ` Michael Ströder
2021-02-04 22:53 ` Juliusz Chroboczek
2021-02-05 9:59 ` Michael Ströder
2021-02-05 10:05 ` Michael Ströder
2021-02-05 11:03 ` Juliusz Chroboczek
2021-02-05 11:22 ` Juliusz Chroboczek
2021-02-05 14:19 ` Michael Ströder
2021-02-05 20:40 ` Michael Ströder
2021-02-10 18:23 ` [Galene] use of closed network connection Michael Ströder
2021-02-10 20:30 ` [Galene] " Toke Høiland-Jørgensen
2021-02-11 14:59 ` Juliusz Chroboczek
2021-02-11 15:17 ` Juliusz Chroboczek
2021-02-11 15:56 ` Toke Høiland-Jørgensen
2021-02-11 18:08 ` Juliusz Chroboczek
2021-02-11 18:20 ` Toke Høiland-Jørgensen
2021-03-02 1:02 ` Dave Taht
2021-02-14 16:32 ` Juliusz Chroboczek [this message]
2021-02-14 17:21 ` [Galene] Re: Frozen videos [was: use of closed network connection] Toke Høiland-Jørgensen
2021-02-11 15:02 ` [Galene] Re: use of closed network connection Juliusz Chroboczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.galene.org/postorius/lists/galene.lists.galene.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtw6k3tk.wl-jch@irif.fr \
--to=jch@irif.fr \
--cc=galene@lists.galene.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox