[Galene] build failure "os.ErrDeadlineExceeded"

[Galene] build failure "os.ErrDeadlineExceeded"

[Michael Ströder]

HI!

On openSUSE Leap 15.2 and SLE 15SP2 I get this build error [1]:

ice/ice.go:238:13: undefined: os.ErrDeadlineExceeded

Hmm, IIRC this used to work.

go1.14-1.14.2-lp152.1.2 is installed for the failed builds.

On Leap 15.3 and Tumbleweed newer go version 1.15 is used and build
succeeds.

See [2] for overview over versions.

I'm still not familiar with go-lang. Could someone please point me in
the right direction?

Ciao, Michael.

[1]
https://build.opensuse.org/build/home:stroeder:network/openSUSE_Leap_15.2/x86_64/galene/_log

[2] https://build.opensuse.org/package/show/home:stroeder:network/galene

[Galene] Re: build failure "os.ErrDeadlineExceeded"

[Juliusz Chroboczek]

Thanks for the report, I'll try to remember to test under Go 1.13 in the
future.

commit 0f7cbe570115e71d60d70439c4d641e2c2d32281
Author: Juliusz Chroboczek <jch@irif.fr>
Date:   Tue Mar 2 21:54:35 2021 +0100

    Replace use of os.ErrTimeout by our own value.
    
    ErrTimeout was introduced in Go 1.15, while we support 1.13 and later.
    Thanks to Michael Ströder for the report.

[Galene] Re: build failure "os.ErrDeadlineExceeded"

[Michael Ströder]

On 3/2/21 9:57 PM, Juliusz Chroboczek wrote:
> Thanks for the report, I'll try to remember to test under Go 1.13 in the
> future.

Cut release 0.3.2?

Otherwise I have to add a back-port patch to the package...

Ciao, Michael.

> commit 0f7cbe570115e71d60d70439c4d641e2c2d32281
> Author: Juliusz Chroboczek <jch@irif.fr>
> Date:   Tue Mar 2 21:54:35 2021 +0100
> 
>     Replace use of os.ErrTimeout by our own value.
>     
>     ErrTimeout was introduced in Go 1.15, while we support 1.13 and later.
>     Thanks to Michael Ströder for the report.

[Galene] Re: build failure "os.ErrDeadlineExceeded"

[Juliusz Chroboczek]

> Cut release 0.3.2?

Sure.  Could you first confirm that the patch fixes your issue?

[Galene] Re: build failure "os.ErrDeadlineExceeded"

[Michael Ströder]

On 3/2/21 10:13 PM, Juliusz Chroboczek wrote:
>> Cut release 0.3.2?
> 
> Sure.  Could you first confirm that the patch fixes your issue?

Yes, 0f7cbe5 seems to build just fine on Leap 15.2:

https://build.opensuse.org/package/binaries/home:stroeder:branches:home:stroeder:network/galene/openSUSE_Leap_15.2

See _service for revision/version details.

Go, go, go...

Ciao, Michael.