[Galene] ICE Agent can not be restarted when gathering [was: Yunohost galene]

[Juliusz Chroboczek <jch@irif.fr>]

>> gotOffer: ICE Agent can not be restarted when gathering

> It happens all the time for remote clients: it just disconnects after a while…

It's definitely a bug in Pion (that should either be fixed in Pion or
worked around in Galène), but as far as I can tell one that should not
trigger unless you've got broken connectivity.

And, indeed, the log that you sent indicates that you've got some
networking issues:

  Aug 01 15:20:09 galene[516]: 2021/08/01 15:20:09 Relay test failed: timeout
  Aug 01 15:20:09 galene[516]: 2021/08/01 15:20:09 Perhaps you didn't configure a TURN server?

The sequence of events is as follows:

  1. the client starts a video by sending an offer;
  2. the server sends an answer and starts ICE candidate gathering;
  3. the client detects the failure after 30s or so and sends an ICE restart;
  4. the candidate gathering at the server isn't done yet, hence the error.

There are two things here that shouldn't happen if the network is
functioning: the candidate gathering shouldn't take so long, and the
client shouldn't be attempting to restart ICE.  Both of these indicate
that there's a firewall in the way and that no TURN server is accessible.

-- Juliusz