[Galene] CSS cleanup

[Galene] CSS cleanup

[Valent@MeshPoint]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi Juliusz and list,

I started to clean up the CSS. Let me know if this PR makes sense as a 
first step: it groups all z-index values in one place, so they're not 
scattered all over galene.css:
https://github.com/jech/galene/pull/337

I also sent a second one for the sidebarnav. Its width was set in the 
.js file, so I moved it into galene.css so all numbers for adjusting the 
UI/UX experience is in one place:
https://github.com/jech/galene/pull/338

I tested both patched independently and then together, but test them 
also on your systems.

Any comments and constructive feedback is welcome.

Best regards,
Valent

[-- Attachment #2: Type: text/html, Size: 1843 bytes --]

[Galene] Re: CSS cleanup

[Juliusz Chroboczek]

Hello Valent.

> https://github.com/jech/galene/pull/337
> https://github.com/jech/galene/pull/338

I've merged both PRs, in the opposite order (since #338 was easier to
review) and after linearising your history.  They're live at galene.org.

Thanks,

-- Juliusz

[Galene] Re: CSS cleanup

[Valent@MeshPoint]

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

Hi Juliusz,

Thank you, that is great to hear.

This next PR fixes the layout below the top bar when the font size 
changes. I also added a comment explaining how the height is calculated. 
Please let me know if you prefer a shorter comment or no comments at 
all.

https://github.com/jech/galene/pull/339

I tested this change on Galene running locally.

I just noticed that I made the same mistake again, I opened this PR from 
my fork’s master after merging the patch there, so it includes an extra 
merge commit. Sorry about that. Next time I’ll open the PR directly from 
a separate branch, with only the patch commit.

Best regards,
Valent



------ Original Message ------
From "Juliusz Chroboczek" <jch@irif.fr>
To "Valent@MeshPoint" <valent@meshpointone.com>
Cc "galene@lists.galene.org" <galene@lists.galene.org>
Date 4.10.2026. 22:36:12
Subject Re: [Galene] CSS cleanup

>Hello Valent.
>
>>https://github.com/jech/galene/pull/337
>>https://github.com/jech/galene/pull/338
>
>I've merged both PRs, in the opposite order (since #338 was easier to
>review) and after linearising your history.  They're live at galene.org.
>
>Thanks,
>
>-- Juliusz

[-- Attachment #2: Type: text/html, Size: 4680 bytes --]

[Galene] Re: CSS cleanup

[Juliusz Chroboczek]

> https://github.com/jech/galene/pull/339

It looks like you've closed the PR.  My guess is that you did the PR for
your master branch, then rewrote the master branch.  GitHub's PRs are
fragile (they're not a very good design, IMHO), I recommend using a
dedicated feature branch for each PR.

Oh, and there's no need to duplicate your submissions across GitHub and
the mailing list: please use either one or the other, at your choice.

-- Juliusz